Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recent winners table #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Complexlity
Copy link
Contributor

@Complexlity Complexlity commented Oct 1, 2024

The current recent winners table takes in all the win data for a certain period (three months I believe).
If you try to sort by date or pay size, the whole table changes. This is because the sort doesn't use the actual recent wins shown to the user. It uses the entire data (many not shown).

Example Vault: przPool on Arbitrum
current:
initial

current (sorted by date) :
issue

fix (sorted by date) :
fix

Since there's no pagination, it’s un-intuitive to show data that is not currently seen by the user

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cabana-builders ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 10:52am
cabana-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 10:52am

Copy link

vercel bot commented Oct 1, 2024

@Complexlity is attempting to deploy a commit to the G9 Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@Ncookiez
Copy link
Member

Ncookiez commented Oct 2, 2024

Since there's no pagination, it’s un-intuitive to show data that is not currently seen by the user

I agree, but I think adding some form of pagination would be a better fix than reducing the scope of the sorting functionality to a total of 6 rows/entries.

I think adding a "show more" button that when clicked, expands the card (to fit maybe to 10 entries?) and makes the card content scrollable (so you could scroll through to see all the winners) would be ideal.

@Complexlity
Copy link
Contributor Author

Since there's no pagination, it’s un-intuitive to show data that is not currently seen by the user

I agree, but I think adding some form of pagination would be a better fix than reducing the scope of the sorting functionality to a total of 6 rows/entries.

I think adding a "show more" button that when clicked, expands the card (to fit maybe to 10 entries?) and makes the card content scrollable (so you could scroll through to see all the winners) would be ideal.

Makes sense. Did some updates.

Here's how it looks now:

final_recent_wins.mp4

Only the English translation has been changed now (for the show less text). If the change is approved, I can do the other translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants