Remove bitvectors width from the value tag. #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1740. We can do this because the values (WordVal) already has its width, so we don't need to store it again.
RyanGlScott
reviewed
Sep 17, 2024
src/Cryptol/Backend.hs
Outdated
| @@ -295,7 +297,7 @@ class MonadIO (SEval sym) => Backend sym where | |||
| bitAsLit :: sym -> SBit sym -> Maybe Bool | |||
|
|
|||
| -- | The number of bits in a word value. | |||
| wordLen :: sym -> SWord sym -> Integer | |||
| wordLen' :: f sym -> SWord sym -> Integer | |||
There was a problem hiding this comment.
I wonder if we should rename f to proxy to signal the intent that this argument is never used at runtime.
src/Cryptol/Backend.hs
Outdated
| @@ -813,3 +815,7 @@ type FPArith2 sym = | |||
| SFloat sym -> | |||
| SFloat sym -> | |||
| SEval sym (SFloat sym) | |||
|
|
|||
| wordLen :: forall sym. Backend sym => sym -> SWord sym -> Integer | |||
| wordLen _ x = wordLen' (Nothing :: Maybe sym) x | |||
There was a problem hiding this comment.
Similarly, I wonder if we should pass Proxy @sym instead of Nothing :: Maybe sym here (and elsewhere in this PR where we use Nothing :: Maybe sym.
src/Cryptol/Eval/Generic.hs
Outdated
| valueToChar sym (VWord 8 wval) = | ||
| valueToChar sym (VWord wval) = |
There was a problem hiding this comment.
This change appears to have changed the semantics of this function slightly, as it now matches any word size instead of just 8-bit words. Perhaps the pattern guards below should check that the wordValWidth is 8?
RyanGlScott
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1740. We can do this because the values (WordVal) already has its width, so we don't need to store it again.