[Snyk + GH Actions] Update requirements #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickumia-reisys
force-pushed
the
requirement-patches
branch
from
a2f7800
to
1991e4a
Compare
nickumia-reisys
commented
Mar 29, 2023
requirements.txt
Outdated
| cryptography==39.0.1 | ||
| cryptography==40.0.1 |
There was a problem hiding this comment.
Seems questionable...
There was a problem hiding this comment.
This one is more concerning, as I know we've had trouble with crypto and authenticating with the s3 bucket... I would deploy this to dev and test run the sitemap command to see if there are any failures. https://cryptography.io/en/latest/changelog/#v40-0-0
nickumia-reisys
commented
Mar 29, 2023
requirements.txt
Outdated
| ckanext-envvars==0.0.2 | ||
| ckanext-envvars==0.0.3 |
There was a problem hiding this comment.
What? How? ... uhh, oh...😌 just CKAN 2.10 support: https://github.com/okfn/ckanext-envvars/releases/tag/v0.0.3
nickumia-reisys
commented
Mar 29, 2023
requirements.txt
Outdated
Comment on lines
94
to
96
| watchdog==2.2.1 | ||
| watchdog==3.0.0 |
There was a problem hiding this comment.
Also seems suspicious..
There was a problem hiding this comment.
nickumia-reisys
force-pushed
the
requirement-patches
branch
from
1991e4a
to
049946b
Compare
robert-bryson
previously approved these changes
Mar 30, 2023
nickumia-reisys
force-pushed
the
requirement-patches
branch
6 times, most recently
from
e5585b0
to
3f1b0c7
Compare
nickumia-reisys
force-pushed
the
requirement-patches
branch
from
3f1b0c7
to
5404ff8
Compare
|
This is defunct as well, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update requirements
requirements.in+requirements.txt