-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4432 new mission #221
4432 new mission #221
Conversation
Good first pass, Robbie. Here's some feedback I see straight away. Home page:
About page:
|
8313a4b
to
47985e2
Compare
47985e2
to
dc76d5f
Compare
Well, I can't approve my own PR, but the changes look great! Thanks @btylerburton! |
b93eec0
to
2c90be8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i noticed in the About Us
section, the background image and separation in the Figma wireframes doesn't appear. Maybe intentional? The image does look a bit pixelated in figma:
Also in About Us
, to @FuhuXia's point in the chat the other day, the (very cool) image's text is a bit small, esp with the margins that shrink everything a bit more than the figma renderings. Almost feels like that graphic could span the width of the page on its own
Looks awesome after break point!
Made one small comment on line 50 of pages/about.html regarding pluralizing "Technology Transformation Services"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new page is very informative and has a nicely integrated decision. I love the work put into this ❤️
P.S. The text in the diagram on the 'about us' page is a bit small, but I think it looks better currently than it does with the breakpoint.
Converting this to a draft until I can put in the required changes. |
This PR is ready for another review. |
Co-authored-by: nickumia <[email protected]>
LGTM |
related to GSA/data.gov#4432