Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4432 new mission #221

Merged
merged 30 commits into from
Mar 5, 2024
Merged

4432 new mission #221

merged 30 commits into from
Mar 5, 2024

Conversation

robert-bryson
Copy link
Contributor

related to GSA/data.gov#4432

@robert-bryson robert-bryson marked this pull request as ready for review February 2, 2024 19:24
@btylerburton
Copy link
Contributor

Good first pass, Robbie. Here's some feedback I see straight away.

Home page:

  • The "About Data.gov" block should be removed from the home page
  • Mission section column width should be adjusted to match comps
  • Background image should be scaled appropriately and alpha value adjusted to match comps

About page:

  • Remove links at top of page
  • Add missing two column layout changes
  • Add border for media inquiries box

@robert-bryson robert-bryson force-pushed the 4432-new-mission branch 2 times, most recently from 8313a4b to 47985e2 Compare February 13, 2024 17:08
@robert-bryson
Copy link
Contributor Author

Well, I can't approve my own PR, but the changes look great! Thanks @btylerburton!

@btylerburton btylerburton requested a review from a team February 20, 2024 17:11
pages/about.html Outdated Show resolved Hide resolved
Copy link
Member

@tdlowden tdlowden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed in the About Us section, the background image and separation in the Figma wireframes doesn't appear. Maybe intentional? The image does look a bit pixelated in figma:

image

Also in About Us, to @FuhuXia's point in the chat the other day, the (very cool) image's text is a bit small, esp with the margins that shrink everything a bit more than the figma renderings. Almost feels like that graphic could span the width of the page on its own

image

Looks awesome after break point!
image

Made one small comment on line 50 of pages/about.html regarding pluralizing "Technology Transformation Services"

Copy link
Contributor

@nickumia nickumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new page is very informative and has a nicely integrated decision. I love the work put into this ❤️

P.S. The text in the diagram on the 'about us' page is a bit small, but I think it looks better currently than it does with the breakpoint.

pages/about.html Outdated Show resolved Hide resolved
pages/about.html Show resolved Hide resolved
pages/index.html Show resolved Hide resolved
pages/about.html Outdated Show resolved Hide resolved
@btylerburton btylerburton marked this pull request as draft February 28, 2024 20:38
@btylerburton
Copy link
Contributor

Converting this to a draft until I can put in the required changes.

@btylerburton btylerburton self-assigned this Mar 4, 2024
@btylerburton btylerburton marked this pull request as ready for review March 4, 2024 23:00
@btylerburton btylerburton requested a review from a team March 4, 2024 23:00
@btylerburton
Copy link
Contributor

This PR is ready for another review.

@FuhuXia
Copy link
Member

FuhuXia commented Mar 5, 2024

LGTM

@btylerburton btylerburton merged commit 92b71a2 into main Mar 5, 2024
6 checks passed
@btylerburton btylerburton deleted the 4432-new-mission branch March 5, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants