Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new page featuring Data.gov vision/mission #4432

Closed
1 of 4 tasks
hkdctol opened this issue Aug 24, 2023 · 23 comments
Closed
1 of 4 tasks

Create new page featuring Data.gov vision/mission #4432

hkdctol opened this issue Aug 24, 2023 · 23 comments
Assignees

Comments

@hkdctol
Copy link
Contributor

hkdctol commented Aug 24, 2023

User Story

In order to share Data.gov vision/mission statements, Data.gov needs to create a new page featuring this content linked from home page.

Acceptance Criteria

  • GIVEN user navigates to data.gov
    THEN there is a link to a page that features Data.gov vision and mission statements.

Sketch

  • Review samples of other website pages featuring vision/mission
  • Design layout/graphics of a page featuring Data.gov vision/mission
  • Create link from data.gov home page
@hkdctol hkdctol self-assigned this Aug 24, 2023
@hkdctol
Copy link
Contributor Author

hkdctol commented Nov 28, 2023

We have mission/vision language we agreed to https://docs.google.com/document/d/1N3q6PQooi037OwRQArnfbttImcuqFwSk7DbJNMnLkic/edit?usp=sharing

@hkdctol
Copy link
Contributor Author

hkdctol commented Dec 1, 2023

@CarolinaC-REI I didn't necessarily have a strong reaction to one example over another, but here are some https://docs.google.com/document/d/1LefM-bmv0_YKM6jWMZwowK1qOwYKRHRZ6DpDMyNMDBk/edit?usp=sharing

@CarolinaC-REI
Copy link

@hkdctol Thank you for sharing the example document. I will work on a few mockup options this week. Should be able to share with you and the team by beginning of next week.

@CarolinaC-REI
Copy link

CarolinaC-REI commented Dec 14, 2023

@hkdctol
Copy link
Contributor Author

hkdctol commented Dec 15, 2023

@crysacarter and others please review and comment

@hkdctol
Copy link
Contributor Author

hkdctol commented Dec 20, 2023

I like the third approach which was mission leading to another page, with the metrics graphs moved to beneath on main page

@btylerburton
Copy link
Contributor

Pages 9-11 look really nice. I believe that is the same option Hyon was leaning towards.

@crysacarter
Copy link

I'm in the same camp - The third approach

@CarolinaC-REI
Copy link

@btylerburton Please find attached the images for the mission section. Please let me know if you need anything else. Thank you
mission-images.zip

@btylerburton
Copy link
Contributor

Thank you for the setup @CarolinaC-REI . I'm going to move this in the sprint backlog as it's ready for implementation.

@FuhuXia
Copy link
Member

FuhuXia commented Feb 2, 2024

The graphs do not look right after the change.

Before
image

After
image

@hkdctol
Copy link
Contributor Author

hkdctol commented Feb 2, 2024

It's duplicative to have both the About Data.gov and Mission sections--shouldn't it be just the Mission section now--and then the About page has the link to the timeline?

@hkdctol
Copy link
Contributor Author

hkdctol commented Feb 2, 2024

Also in the current Mission section -- the word "and" is where there is a blue dot in the background image--so it's hard to see--can the placement be adjusted? Not sure if that's a question for @CarolinaC-REI

@btylerburton
Copy link
Contributor

I added my feedback to the PR. We shouldn't need any new assets from Carolina.

The graphs do not look right after the change.

I don't see this issue, @FuhuXia. Perhaps Robbie fixed it, or you were resizing across a breakpoint? The chart has never been fully responsive. If you change breakpoints it needs a page refresh to repaint.

@FuhuXia
Copy link
Member

FuhuXia commented Feb 15, 2024

@btylerburton ok, the chart issue is likely due to caching. it is fine incognito.

@hkdctol
Copy link
Contributor Author

hkdctol commented Feb 15, 2024

I reviewed again, and on the About page, I would delete the section titled "What standards were used to develop the metadata displayed on Data.gov?" because it's not accurate (there are other than DCAT datasets) and the later section links to what will be the updated how to get data on Data.gov article, which will be more detailed/accurate

@rshewitt
Copy link
Contributor

idk if it's worth fixing but this is what the graphic looks like in chrome configured to dark mode

Image

@btylerburton
Copy link
Contributor

@CarolinaC-REI while we're at it, if there's any tweaks we could do to help with that dark mode issue above, that would be helpful. thanks!

@CarolinaC-REI
Copy link

@btylerburton Sure thing, I will adjust to make sure they are dark mode friendly. Thank you for all your feedback.

@CarolinaC-REI
Copy link

CarolinaC-REI commented Feb 27, 2024

@btylerburton @robert-bryson Please find attached the new assets. I have added a new version for the background image, please let me know if you are still having issues on fitting the image with the content. Thank you
new-assets.zip

@CarolinaC-REI
Copy link

@btylerburton Regarding the dark mode issue. I have tested on my end and was not able to replicate the issue. I checked with @rshewitt and it seem that this is no longer an issue. Please let me know if you are still seeing on your end and I would be happy to take another look.

@robert-bryson
Copy link
Contributor

All items in new-assets.zip uploaded to s3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄 Closed
Development

No branches or pull requests

8 participants