Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all OGG files using OptiVorbis #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CyndaquilDAC
Copy link

I recently discovered OptiVorbis while looking for ways to optimize large OGG files for my own project, and figured that since FNF is gonna have a LOTTTTT of audio, it might be something that interested you guys. I ran it on every .ogg file in the assets folder. It's web based and really easy to use, and is completely lossless since it simply fixes inoptimal encoding. https://optivorbis.github.io/OptiVorbis/

Copy link

@moxie-coder moxie-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems nice as long as it doesn't cause too much compression

@CyndaquilDAC
Copy link
Author

seems nice as long as it doesn't cause too much compression

it doesnt change audio quality at all, as I mentioned. it only optimizes encoding.

Copy link

@Raltyro Raltyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sickk, how much disk space this pr saved btw

@CyndaquilDAC
Copy link
Author

pretty sickk, how much disk space this pr saved btw

I didnt think to check, but probably not TOO mcuh right now. This is more something thatll add up in the future

@EliteMasterEric EliteMasterEric added the status: pending triage The bug or PR has not been reviewed yet. label Sep 25, 2024
@EliteMasterEric
Copy link
Member

This looks great but I'm not going to merge this particular commit in case of issues. I will try to figure out how to make a PR that credits you though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage The bug or PR has not been reviewed yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants