-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Controller Rebinding, Refactoring Controls System and Reworking Button Icons #81
Conversation
…nstead of virtual button name. Adding new icons.
Creating control binding menu and setting up backend for updating bindings. Still very much a wip proof of concept. Sticks are still not supported, and there are probably several bugs.
Also adding actions for resetting and clearing bindings
Fixing missing dpad icons. Fixing issue with default deadzone not getting set or reset correctly. Fixing bug where Positive and Negative directions on an axis couldn't be bound to the same virtual button.
I believe this is now working, and is ready to merge. There may still be a few binding issues, but some of these come from Foster, so we may want to look into fixing them separately. Mainly, a few keyboard keys don't seem to get registered as "Pressed" correctly, like the Windows button and the numlock button. I think this is probably acceptable for now, but we can revisit it if people complain. There's also a known bug in Foster with Controllers where the select and home buttons seem to be flipped. I have a temporary workaround for this, but we may need to follow up on this if it gets fixed in Foster. |
This is still Work in Progress and is not ready to merge yet.
This PR Implements Controller/Keyboard rebinding into the game. This includes new menus to handle the rebinding process, and reworking the backend systems as well to be able to support it.
This also reworks how we determine button icons to be based on the key/button name.
Todo:
Resolves #52