Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reapply second pass for metadata types #6568

Closed
wants to merge 1 commit into from
Closed

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 18, 2024

Description

Closes #6567

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #6568 will not alter performance

Comparing sophie/6567 (9c26137) with master (15c8298)

Summary

✅ 22 untouched benchmarks

@sdankel sdankel closed this Sep 18, 2024
@sdankel sdankel deleted the sophie/6567 branch September 18, 2024 21:55
@sdankel sdankel restored the sophie/6567 branch September 18, 2024 21:55
@sdankel sdankel deleted the sophie/6567 branch September 18, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing forc unit test: ok_vec_buffer_ownership
1 participant