Skip to content

Commit

Permalink
backend: first sign packages, then upload them to Pulp
Browse files Browse the repository at this point in the history
  • Loading branch information
FrostyX authored and praiskup committed Sep 27, 2024
1 parent 70b4dbc commit d616056
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions backend/copr_backend/background_worker_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,12 +697,6 @@ def _sign_built_packages(self):
:param pkg: path to the source package
"""

# Ideally, we would like to have this decision in our storage classes
if self.job.storage == StorageEnum.pulp:
self.log.info("Not going to sign pkgs, Pulp will take care of that")
return

self.log.info("Going to sign pkgs from source: %s in chroot: %s",
self.job.task_id, self.job.chroot_dir)

Expand Down Expand Up @@ -1020,12 +1014,12 @@ def build(self, attempt):

# raise error if build failed
try:
self._upload_results_to_storage()
self._check_build_success()
# Build _succeeded_. Do the tasks for successful run.
failed = False
if self.opts.do_sign:
self._sign_built_packages()
self._upload_results_to_storage()
self._do_createrepo()
self._parse_results()
build_details = self._get_build_details(self.job)
Expand Down

0 comments on commit d616056

Please sign in to comment.