Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile for linux #311

Closed
wants to merge 1 commit into from
Closed

fix compile for linux #311

wants to merge 1 commit into from

Conversation

jopadan
Copy link

@jopadan jopadan commented Jul 16, 2024

  • add forsaken.sh with luasocket preload
  • reduce multiple VECTOR structs
  • remove scripts/socket*
  • remove useless executable permissions
  • make forsaken-data a submodule in data
  • create missing dirs and adapt ignores for content
  • adapt to enet changes

@chino
Copy link
Member

chino commented Jul 16, 2024

Sorry, but we have no desire to accept this or waste any more time on it. Sub modules introduce annoyances and the data folder is optionally done various ways by the user. Chmod files is pointless changes. You're changing massive amount of stuff is one big commit that looks largely pointless. The makefile changes are a mix of pointless changes and stuff that looks wrong. Why are you getting rid of lua-socket? Why are you deleting the scripts folder? Why rework working structs for a project that's in maintenance mode and works on many platforms requiring a lot of testing? There is a million things that could be cleaned up and nobody is looking to waste time on that. Please only submit things that are worth it our time.

@chino chino closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants