Various fixes for makefile and cleaning up errors reported by new sanitizer #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chino
force-pushed
the
various-fixes
branch
2 times, most recently
from
1261292
to
1a4d0a6
Compare
These are just temporary string holders that we end up going over by 1.
RandomStartPosModify still overflows but this stops sanitize from throwing an error which was triggered by casting the value back from a float to an int16. Likewise in RGBA_MAKE we had to cast `a` to a larger size to avoid the error messages.
We did not want a size of a pointer but instead size of the underlying memory storage.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits...