Zero-length array allocation inspection (idea)

botany/src/main/java/binnie/botany/Botany.java

@@ -82,11 +82,6 @@ public IBinnieGUID[] getGUIDs() {
 		return BotanyGUI.values();
 	}
 
-	@Override
-	public Class<?>[] getConfigs() {
-		return new Class[0];
-	}
-
 	@Override
 	public IPacketID[] getPacketIDs() {
 		return PacketID.values();

botany/src/main/java/binnie/botany/genetics/FlowerRoot.java

@@ -209,11 +209,6 @@ public IAllele[] getDefaultTemplate() {
 		return alleles;
 	}
 
-	@Override
-	public IAllele[] getRandomTemplate(Random rand) {
-		return speciesTemplates.values().toArray(new IAllele[0][])[rand.nextInt(speciesTemplates.values().size())];
-	}
-
 	@Override
 	public ArrayList<IFlowerMutation> getMutations(boolean shuffle) {
 		if (shuffle) {

core/src/main/java/binnie/core/AbstractMod.java

@@ -19,6 +19,7 @@
 import binnie.core.network.IPacketProvider;
 import binnie.core.network.packet.MessageBinnie;
 import binnie.core.proxy.IProxyCore;
+import binnie.core.util.EmptyHelper;
 
 public abstract class AbstractMod implements IPacketProvider, IInitializable {
 	protected final List<IInitializable> modules;
@@ -40,15 +41,15 @@ public AbstractMod() {
 
 	@Override
 	public IPacketID[] getPacketIDs() {
-		return new IPacketID[0];
+		return EmptyHelper.PACKET_IDS_EMPTY;
 	}
 
 	public IBinnieGUID[] getGUIDs() {
-		return new IBinnieGUID[0];
+		return EmptyHelper.BINNIE_GUIDS_EMPTY;
 	}
 
 	public Class<?>[] getConfigs() {
-		return new Class[0];
+		return EmptyHelper.CLASS_ARRAY_EMPTY;
 	}
 
 	public abstract IProxyCore getProxy();

core/src/main/java/binnie/core/block/BlockMetadata.java

@@ -1,7 +1,6 @@
 package binnie.core.block;
 
 import javax.annotation.Nullable;
-import java.util.ArrayList;
 import java.util.List;
 
 import net.minecraft.block.Block;
@@ -40,20 +39,18 @@ public static void getDrops(NonNullList<ItemStack> drops, IBlockMetadata block,
 	}
 
 	public static boolean breakBlock(IBlockMetadata blockMetadata, @Nullable EntityPlayer player, World world, BlockPos pos) {
-		List<ItemStack> drops = new ArrayList<>();
+		List<ItemStack> drops = null;
 		Block block = (Block) blockMetadata;
 		TileEntityMetadata tile = TileEntityMetadata.getTile(world, pos);
 		if (tile != null && !tile.hasDroppedBlock()) {
 			drops = block.getDrops(world, pos, world.getBlockState(pos), 0);
 		}
 		boolean hasBeenBroken = world.setBlockToAir(pos);
-		if (hasBeenBroken && !world.isRemote && drops.size() > 0 && (player == null || !player.capabilities.isCreativeMode)) {
+		if (hasBeenBroken && !world.isRemote && drops != null && (player == null || !player.capabilities.isCreativeMode)) {
 			for (ItemStack drop : drops) {
 				spawnAsEntity(world, pos, drop);
 			}
-			if (tile != null) {
-				tile.dropBlock();
-			}
+			tile.dropBlock();
 		}
 		return hasBeenBroken;
 	}

core/src/main/java/binnie/core/block/TileEntityMetadata.java

@@ -40,8 +40,10 @@ public static ItemStack getItemStack(final Block block, final int damage) {
 		return itemStack;
 	}
 
+	private static final int MAX_ITEM_DAMAGE = 16387;
+
 	public static void setItemDamage(final ItemStack item, final int i) {
-		item.setItemDamage((i < 16387) ? i : 16387);
+		item.setItemDamage((i < MAX_ITEM_DAMAGE) ? i : MAX_ITEM_DAMAGE);
 		final NBTTagCompound tag = new NBTTagCompound();
 		tag.setInteger("meta", i);
 		item.setTagCompound(tag);
@@ -76,7 +78,7 @@ public NBTTagCompound getUpdateTag() {
 	@Override
 	public void readFromNBT(final NBTTagCompound nbt) {
 		super.readFromNBT(nbt);
-		if(world!=null)
+		if (world != null)
 			setTileMetadata(nbt.getInteger("meta"), world.isRemote);
 		else
 			this.meta = nbt.getInteger("meta");

core/src/main/java/binnie/core/circuits/BinnieCircuit.java

@@ -14,8 +14,10 @@ public class BinnieCircuit implements ICircuit {
 	private final int limit;
 	private final List<String> tooltips;
 
+	private static final int TOOLTIPS_ARRAY_CAPACITY = 8;
+
 	public BinnieCircuit(final String uid, final int limit, final ICircuitLayout layout, final ItemStack itemStack) {
-		this.tooltips = new ArrayList<>();
+		this.tooltips = new ArrayList<>(TOOLTIPS_ARRAY_CAPACITY);
 		this.uid = "for.binnie.circuit." + uid;
 		this.limit = limit;
 		ChipsetManager.circuitRegistry.registerCircuit(this);

core/src/main/java/binnie/core/config/ConfigProperty.java

@@ -5,12 +5,14 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+import org.apache.commons.lang3.StringUtils;
+
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.FIELD})
 public @interface ConfigProperty {
 	String key();
 
-	String category() default "";
+	String category() default StringUtils.EMPTY;
 
 	String[] comment() default {};
 

core/src/main/java/binnie/core/genetics/AlleleHelper.java

@@ -3,7 +3,7 @@
 import java.util.Locale;
 import java.util.regex.Pattern;
 
-import binnie.core.util.EmptyHelper;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.text.WordUtils;
 
 import forestry.api.core.EnumHumidity;
@@ -205,12 +205,12 @@ private static String getUid(String key, String valueName, boolean needCapitaliz
 		if (needCapitalize) {
 			valueName = WordUtils.capitalize(valueName.toLowerCase(Locale.ENGLISH));
 		}
-		valueName = PATTERN_REPLACEMENT.matcher(valueName).replaceAll(EmptyHelper.EMPTY_STRING);
+		valueName = PATTERN_REPLACEMENT.matcher(valueName).replaceAll(StringUtils.EMPTY);
 		return "forestry." + key + valueName;
 	}
 
 	private static String toAlleleDisplay(@Nullable String key, String valueName) {
-		String name = PATTERN_REPLACEMENT.matcher(valueName.toLowerCase()).replaceAll(EmptyHelper.EMPTY_STRING);
+		String name = PATTERN_REPLACEMENT.matcher(valueName.toLowerCase()).replaceAll(StringUtils.EMPTY);
 		if (key == null) {
 			return I18N.localise("forestry.allele." + name);
 		}