AWS Bedrock embeddings call retry extension #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryHengZJ
reviewed
Jul 31, 2024
packages/components/nodes/embeddings/AWSBedrockEmbedding/AWSBedrockEmbedding.ts
Outdated
Show resolved
Hide resolved
HenryHengZJ
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS Bedrock embeddings retry for Titan models added.
Change sends requests to AWS Bedrock in batches, not all in one go and introduces timeout between calls if throttling exception is caught. After every retry, timeout is increased and stays at the value until the end of operation. Retry counter is reset when successful response is returned, but throws exception if there are to many throttling exceptions in a row.
Additional parameter, set by user are max retries and batch size. Current observations show, batch size 50 works well.