Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanFlexgetVersion to process semver strings #183

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

shawnphoffman
Copy link
Contributor

Motivation for changes:

Fix #182 and try to prevent it from happening again without adding complexity to the server repo.

Detailed changes:

Given the complexity flexget currently has in their server versioning, I added a utility that attempts to parse the semver version and clean it up according to the flexget logic. I added tests to help demonstrate some of the edge cases.

  • Handle incomplete semver 3.9 to 3.9.0
  • Handle existing logic 1.2.3.dev to 1.2.3-dev.0
  • Handle other minor use cases.

Originally, I was going to use the coerce function built into semver to handle the 3.9 to 3.9.0 but that removes prerelease tags and they appear to be useful according to tests.

Addressed issues:

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #183 (8acf7e4) into develop (ecd9c49) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop     #183    +/-   ##
=========================================
  Coverage    90.70%   90.71%            
=========================================
  Files          128      128            
  Lines         2743     2745     +2     
  Branches       330      441   +111     
=========================================
+ Hits          2488     2490     +2     
  Misses         251      251            
  Partials         4        4            
Files Changed Coverage Δ
src/core/layout/SideNav/Version.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gazpachoking gazpachoking merged commit b492741 into Flexget:develop Aug 17, 2023
2 checks passed
@gazpachoking
Copy link
Member

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3.9 release causes web ui to render blank due to Semver check failing
2 participants