Skip to content

Commit

Permalink
Merge pull request #209 from Financial-Times/node-versions
Browse files Browse the repository at this point in the history
Update supported Node.js versions
  • Loading branch information
rowanmanning committed Aug 29, 2024
2 parents 681eeef + d9d2b98 commit f15644a
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 8 deletions.
20 changes: 19 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ orbs:
executors:
node:
docker:
- image: cimg/node:18.16-browsers
- image: cimg/node:22.3-browsers
node20_15-browsers:
docker:
- image: cimg/node:20.15-browsers
node18_20-browsers:
docker:
- image: cimg/node:18.20-browsers
jobs:
checkout:
docker:
Expand Down Expand Up @@ -40,6 +46,8 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -51,6 +59,8 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand All @@ -62,6 +72,8 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
filters:
tags:
only: /^v\d+\.\d+\.\d+(-.+)?/
Expand Down Expand Up @@ -95,6 +107,8 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
- tool-kit/build:
name: tool-kit/build-<< matrix.executor >>
requires:
Expand All @@ -103,6 +117,8 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
- tool-kit/test:
name: tool-kit/test-<< matrix.executor >>
requires:
Expand All @@ -111,3 +127,5 @@ workflows:
parameters:
executor:
- node
- node20_15-browsers
- node18_20-browsers
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
5 changes: 4 additions & 1 deletion .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,7 @@ plugins:
hooks: {}
options:
"@dotcom-tool-kit/circleci":
nodeVersion: "18.16-browsers"
nodeVersion:
- '22.3-browsers'
- '20.15-browsers'
- '18.20-browsers'
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@
"@dotcom-tool-kit/jest": "^3.4.0"
},
"engines": {
"node": "16.x || 18.x",
"npm": "7.x || 8.x || 9.x"
"node": "18.x || 20.x || 22.x",
"npm": "8.x || 9.x || 10.x"
},
"volta": {
"node": "18.16.0"
"node": "20.15.0"
}
}

0 comments on commit f15644a

Please sign in to comment.