Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some missing docstrings to devdocs #964

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

termi-official
Copy link
Member

Found that some of the docstrings were not exposed to the docs.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (cf97ee5) to head (4f2f25e).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          36       36           
  Lines        5438     5438           
=======================================
  Hits         5095     5095           
  Misses        343      343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KnutAM KnutAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the missing embedded_det and adding sortfacet_fast. Link would be nice to fix as well, but can also be done elsewhere.

docs/src/devdocs/FEValues.md Outdated Show resolved Hide resolved
docs/src/devdocs/elements.md Show resolved Hide resolved
docs/src/devdocs/FEValues.md Outdated Show resolved Hide resolved
@termi-official termi-official added the awaiting review PR is finished from the authors POV, waiting for feedback label Jun 2, 2024
@fredrikekre fredrikekre merged commit 51437f4 into master Jun 5, 2024
11 checks passed
@fredrikekre fredrikekre deleted the do/some-missing-internal-docs branch June 5, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review PR is finished from the authors POV, waiting for feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants