Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set movie status to unknown if unmonitored from radarr during scan #817

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bonswouar
Copy link

@bonswouar bonswouar commented Jun 14, 2024

Description

Quick & easy first implementation of Monitoring status support in Radarr:
When a movie - which was monitored before - is unmonitored, it won't appear as "requested" in Jellyseerr anymore

Issues Fixed or Closed

@bonswouar bonswouar changed the title feat: set movie status to unknown if unmonitored from radarr during scan feat: set movie status to unknown if unmonitored from radarr during scan [WIP] Jun 14, 2024
@Fallenbagel Fallenbagel marked this pull request as draft June 15, 2024 04:50
@Fallenbagel
Copy link
Owner

Converted to draft as the title states "WIP". Once it's ready feel free to make this pr ready for review

@bonswouar
Copy link
Author

@Fallenbagel Thanks I didn't think about the Draft feature

This is a WIP but it's basically working as I'd expect.
But I could update it with a more specific Monitoring status support if you think it's a good idea?

Only drawback is that if you have lots of Unmonitored movies in Radarr the scan should be slower, as it will request each unmonitored movie in db every time. Let me know if you have some thoughts about this

@bonswouar
Copy link
Author

FYI I've been using this for months and it works as expected.
I suspect some other users might need this functionality, couldn't we merge it?

A more complete monitoring status support wouldn't be very useful imo, at least I didn't encounter any use case

@bonswouar bonswouar changed the title feat: set movie status to unknown if unmonitored from radarr during scan [WIP] feat: set movie status to unknown if unmonitored from radarr during scan Sep 27, 2024
@gauthier-th gauthier-th marked this pull request as ready for review September 27, 2024 14:10
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be merged if it's only Radarr. Could you implement the same logic for Sonarr seasons?
And shouldn't there be a setting to enable/disable this behavior? You may have unmonitored a movie/tv show but still want to keep it as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants