Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an MRJ to set the classloader name #978

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Create an MRJ to set the classloader name #978

wants to merge 4 commits into from

Conversation

modmuss50
Copy link
Member

Sets the class loader name, this means stacktraces indicate what classloader a given class was loaded from.

Screenshot 2024-09-18 at 09 46 21

Questions:

  • What name should the classloader have? I chose fabric over knot as this will be seen by anyone looking at log files, knot is very much an internal name to loader, with little meaning.
  • Should it target java 9? I went with java 17 + to possibly reduce the number of MRJ versions we may need in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfPlayer1 sfPlayer1 sfPlayer1 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modmuss50 @sfPlayer1