Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing normalization, cache normalization #974

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Add missing normalization, cache normalization #974

merged 1 commit into from
Sep 7, 2024

Conversation

sfPlayer1
Copy link
Contributor

No description provided.

@sfPlayer1 sfPlayer1 mentioned this pull request Sep 7, 2024
Closed
@modmuss50
Copy link
Member

modmuss50 commented Sep 7, 2024 •
edited
Loading

This allows the game to start, but still fails when assertions are enabled.

[13:22:51] [INFO] [FabricLoader/GameProvider]: Loading Minecraft 1.21.1 with Fabric Loader 0.16.4
[13:22:51] [ERROR] [FabricLoader/]: Uncaught exception in thread "main"
java.lang.AssertionError
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getCodeSource(KnotClassDelegate.java:520)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getMetadata(KnotClassDelegate.java:363)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:338)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadIntoTarget(KnotClassDelegate.java:195)
	at net.fabricmc.loader.impl.launch.knot.Knot.loadIntoTarget(Knot.java:298)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.setupLogHandler(MinecraftGameProvider.java:381)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.initialize(MinecraftGameProvider.java:357)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:140)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

modmuss50
modmuss50 approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, now working as expected with -ea.

@modmuss50 modmuss50 merged commit 2908ef3 into FabricMC:master Sep 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@modmuss50 modmuss50 modmuss50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfPlayer1 @modmuss50