bug fix and added full run test #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bug fix and added full run test |
|
@lluism -- can you double check why the change I made for R155 (see the CHIME Slack) thx |
:q :w :q Please enter a commit message to explain why this merge is necessary,
|
@profxj I merged the pz_dm and limiting_mag scripts into a pzdm_mag one, with its new call command frb_pzdm_mag. Now the code returns redshift and luminosity info, with same defaults and arguments that were there before. The tests have also been changed to test the new script and not the individual previous ones. Once we confirm all this works, I will delete the two individual pieces (i made a note on it). Tests in test_scripts.py are passed, but still failing here with some package/dependency not found.. Thanks ! |
profxj
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.