Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added target="_blank" in external urls #198

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Added target="_blank" in external urls #198

merged 2 commits into from
Aug 10, 2023

Conversation

A91y
Copy link
Member

@A91y A91y commented Aug 6, 2023 •
edited
Loading

Description

Add target="_blank" in anchor tags within the jsx

Fixes #197

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@netlify
Copy link

netlify bot commented Aug 6, 2023 •
edited
Loading

✅ Deploy Preview for fossc ready!

Name Link
🔨 Latest commit e4458ca
🔍 Latest deploy log https://app.netlify.com/sites/fossc/deploys/64cfbd409f18160008e42897
😎 Deploy Preview https://deploy-preview-198--fossc.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mr-Sunglasses
Copy link
Member

@A91y please mention this PR in the issue.

@A91y A91y mentioned this pull request Aug 6, 2023
Closed
@A91y
Copy link
Member Author

A91y commented Aug 6, 2023

@A91y please mention this PR in the issue.

Addressed

@Mr-Sunglasses Mr-Sunglasses merged commit 64db2b3 into FOSS-Community:main Aug 10, 2023
10 checks passed
@Mr-Sunglasses
Copy link
Member

Thx @A91y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Improvement: Add target="blank" while navigating to external urls
2 participants
@A91y @Mr-Sunglasses