Release DB handle on follower when escalating command #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldoglas
reviewed
Oct 7, 2024
sqlitecluster/SQLitePool.cpp
Outdated
| @@ -87,11 +87,18 @@ void SQLitePool::returnToPool(size_t index) { | |||
| _wait.notify_one(); | |||
| } | |||
|
|
|||
| SQLiteScopedHandle::SQLiteScopedHandle(SQLitePool& pool, size_t index) : _pool(pool), _index(index) | |||
| SQLiteScopedHandle::SQLiteScopedHandle(SQLitePool& pool, size_t index) : _pool(pool), _index(index), _released(true) | |||
There was a problem hiding this comment.
should this start with false instead? Or do we need somewhere to actually change that to false in the code?
There was a problem hiding this comment.
It definitely should.
|
@danieldoglas updated, ready for re-review. |
danieldoglas
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This just releases the DB handle before escalation, freeing it up for others to use.
Fixed Issues
Fixes https://expensify.slack.com/archives/C07PP7QV8P5/p1728324082742299
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes