Log the last time we spontaneously disconnected from the cluster when forked. #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerkaraszewski
changed the title
chiragsalian
previously approved these changes
Sep 18, 2024
cead22
reviewed
Sep 19, 2024
sqlitecluster/SQLiteNode.cpp
Outdated
| @@ -2785,3 +2790,13 @@ void SQLiteNode::kill() { | |||
| peer->reset(); | |||
| } | |||
| } | |||
|
|
|||
| string SQLiteNode::_getLostQuorumLogMessage() const { | |||
| string lostQuormMessage; | |||
There was a problem hiding this comment.
Suggested change
| string lostQuormMessage; | |
| string lostQuorumMessage; |
cead22
reviewed
Sep 19, 2024
sqlitecluster/SQLiteNode.cpp
Outdated
| @@ -1591,12 +1591,14 @@ void SQLiteNode::_onMESSAGE(SQLitePeer* peer, const SData& message) { | |||
| uint64_t commitNum = SToUInt64(message["hashMismatchNumber"]); | |||
| _db.getCommits(commitNum, commitNum, result); | |||
| _forkedFrom.insert(peer->name); | |||
|
|
|||
There was a problem hiding this comment.
This isn't removing the blank line, just the spaces in the blank line
Suggested change
Co-authored-by: Chirag Chandrakant Salian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This adds extra logging to the
Hash mismatchlog lines to indicate if we've recently lost quorum due to a disconnection.It is more-or-less expected that losing quorum while leading will result in a forked DB node. There's no way for the node to anticipate that it is about to lose quorum, and so it will continue committing parallel transaction until it notices the disconnect, at which point it's too late. Another node will begin leading and this node will have commits that it was unable to send.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/384477 https://github.com/Expensify/Expensify/issues/422697
Tests
Artificially setting the timestamp logs:
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes