Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expensify_prod branch #1707

Merged
merged 5 commits into from
May 2, 2024
Merged

Update expensify_prod branch #1707

merged 5 commits into from
May 2, 2024

Conversation

fukawi2
Copy link
Contributor

@fukawi2 fukawi2 commented May 2, 2024

Will self-merge, this code has already been peer reviewed.

Copy link

melvin-bot bot commented May 2, 2024

I see this code uses list. If your primary use case is just checking to see if an item exists in the list, perhaps set is a better choice, as it's much faster for random access. C++ has a variety of data structures available to choose from, so pick the best for your use case.

@fukawi2 fukawi2 merged commit 327fa41 into expensify_prod May 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants