Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update expensify_prod branch #1529

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Update expensify_prod branch #1529

merged 2 commits into from
Jul 7, 2023

Conversation

fukawi2
Copy link
Contributor

@fukawi2 fukawi2 commented Jul 7, 2023

Will self-merge, this code has already been peer reviewed.

NikkiWines and others added 2 commits July 6, 2023 18:36
@NikkiWines
minor style
10b0cb7
@fukawi2
Merge pull request #1528 from Expensify/nikki-regularize-params-prepeek
0e138b2 
Regularize the same parameters in prePeek() that we do for peek() in Auth
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

I see this code uses list. If your primary use case is just checking to see if an item exists in the list, perhaps set is a better choice, as it's much faster for random access. C++ has a variety of data structures available to choose from, so pick the best for your use case.

@fukawi2 fukawi2 merged commit e9d0af1 into expensify_prod Jul 7, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fukawi2 @NikkiWines