Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim content before ready check for addl info #1509

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

bflynn-cms
Copy link
Collaborator

Story: https://qmacbis.atlassian.net/browse/OY2-30169
Endpoint: See github-actions bot comment

Details

Do not allow empty space characters such as space as a valid entry for the additional information field on subsequent submissions.

Changes

  • updated OneMACForm.tsx to trim the additional information field before checking for validity

Implementation Notes

  • This will affect all forms using the OneMACForm including subsequent submission.

Test Plan

  1. Login as a state submitter
  2. Locate a package in Under Review status and initiate the submit subsequent document action
  3. Add an attachment and any text in the additional info field.
  4. Verify the submit button turns active (green)
  5. Remove the additional info text and enter only spaces
  6. Verify the submit button stays inactive (grey) and prevents submittal of the form

Copy link

Endpoint URL - https://d2b98czjx58rfa.cloudfront.net

@bflynn-cms bflynn-cms merged commit 4b70570 into develop Sep 19, 2024
100 of 106 checks passed
@bflynn-cms bflynn-cms deleted the oy2-30169 branch September 19, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants