Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oy2-30166 SubSub Prevent CMS Action #1503

Merged
merged 13 commits into from
Sep 17, 2024
Merged

Oy2-30166 SubSub Prevent CMS Action #1503

merged 13 commits into from
Sep 17, 2024

Conversation

bflynn-cms
Copy link
Collaborator

@bflynn-cms bflynn-cms commented Sep 10, 2024

Story: https://qmacbis.atlassian.net/browse/OY2-30166
Endpoint: See github-actions bot comment

Details

Under some statuses ("Pending - Approval" or "Pending - Canceled" ) CMS users were able to see the submit subsequent documets action. CMS should never have the submit subsequent documents action.

Changes

  • fix bracing issue in actiondelegate.js

Test Plan

  1. Login as a CMS user (such as [email protected], [email protected], and [email protected])
  2. Find a package in any state starting with "Pending - Approval" or "Pending - Canceled" and open it
  3. Verify the action for subsequent document upload is not available

Copy link

Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete

Copy link
Collaborator

@Dark-Knight-1313 Dark-Knight-1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to get unit test

@bflynn-cms bflynn-cms changed the base branch from masterclone to develop September 17, 2024 12:46
@bflynn-cms bflynn-cms merged commit e46999b into develop Sep 17, 2024
7 checks passed
@bflynn-cms bflynn-cms deleted the oy2-30166 branch September 17, 2024 12:48
bflynn-cms added a commit that referenced this pull request Sep 19, 2024
* Update sub sub email language (#1499)

* OY2-28760 - updated language in the sub sub email notifications to match docs 
---------
Co-authored-by: Andie Swift <[email protected]>
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: bflynn-cms <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Dark-Knight-1313 <[email protected]>
Co-authored-by: Mike Dial <[email protected]>

* ensure subsequent submission is only for users with access to submit packages (#1503)

Co-authored-by: Dark-Knight-1313 <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andie Swift <[email protected]>
Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Dark-Knight-1313 <[email protected]>
Co-authored-by: Mike Dial <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants