Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sub sub email language #1499

Merged
merged 28 commits into from
Sep 4, 2024
Merged

Update sub sub email language #1499

merged 28 commits into from
Sep 4, 2024

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Aug 27, 2024

Story: https://qmacbis.atlassian.net/browse/OY2-29760
Endpoint:https://d1xwr2frq98eh7.cloudfront.net/

Details

Minor Language change in sub sub emails to match: Email Notification Confluence

Screenshots

State:
Screenshot 2024-09-03 at 10 26 33 AM

CMS:
Screenshot 2024-09-03 at 10 29 23 AM

Test Plan

  1. Login as test user
  2. Submit a sub sub action on any package which the action is available
  3. Check CMS email notification to ensure it matches the confluence & ticket
  4. Check the State email notification to ensure it also matches confluence & ticket

kristin-at-theta and others added 26 commits August 29, 2023 14:40
* add subsequent submission action (form not yet implemented)

* fix error in action delegate and corresponding tests

* add new forms and config for subsequent submission

* not sure where that came from???

* Add custom success banner

* placeholder in one stream to build parent so that submit can release lock

* fix Cover Letter filter and attachment link for medicaid

* fix navigational back button on form

Let back nav button return you to details page if that is where you came from or to proper tab in package list if that is where you came from

* fix attachment language text per figma - despite nothing in the ACs ;)

* tests to cover subsequent submissions

* consolidate more of the Config

* Update submitWaiverAmendmentSubsequentSubmission.js

* tune required markings

* test updates

had the wrong message in the success banner but realized I maybe shouldn't automate the actual submission without some extra seed data (and holding off on that until reverse chrono seed data is pushed up).

* OY2 24868: Update NOSOs Admin Package Change Log Language (#1352)

* move secondClockStatuses to common configs (#1346)

* Bump @adobe/css-tools from 4.2.0 to 4.3.1 in /services/ui-src (#1355)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* keep current status after subsequent submission

* Bump tough-cookie and @cypress/request (#1332)

Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) and [@cypress/request](https://github.com/cypress-io/request). These dependencies needed to be updated together.

Updates `tough-cookie` from 2.5.0 to 4.1.3
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v2.5.0...v4.1.3)

Updates `@cypress/request` from 2.88.11 to 2.88.12
- [Release notes](https://github.com/cypress-io/request/releases)
- [Changelog](https://github.com/cypress-io/request/blob/master/CHANGELOG.md)
- [Commits](cypress-io/request@v2.88.11...v2.88.12)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
- dependency-name: "@cypress/request"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kristin Grue <[email protected]>

* fix and update subsub tests

* final test update

some pending packages have actions because of the enable withdraw (unrelated to this work) story. Updated those. The tests failing because they can't find a package will be left and those are fixed elsewhere.

* OY2 24628: OneMAC Package Details - Reverse Chronological order (#1338)

Co-authored-by: Valencia McMurray <[email protected]>

* some of the tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Valencia McMurray <[email protected]>
* initial implementation of subsequent submission chronological order

* Update actionDelegate.test.js

* test Subsequent Documentation in reverse chrono

---------

Co-authored-by: Valencia McMurray <[email protected]>
* add emails for subsequent submissions

* lint
re-adding latest activity and updating some attachment steps to match current dev.
* Update serverless.yml

changed x-content-type-options to lowercase to see if the value will change

* Update api-gateway.yml

Another addition to set the x-Content-Type-Options to nosniff

* Update api-gateway.yml

Fix error where code was placed

* Add aws-sdk, esbuild, and configuration to fix the legacy source to kafka

* set default timeout to 2.5minutes for all api lambda (#1475)

* continue pipeline even if issues with seed data (#1478)

---------

Co-authored-by: Dark-Knight-1313 <[email protected]>
Co-authored-by: Mike Dial <[email protected]>
* Update serverless.yml

changed x-content-type-options to lowercase to see if the value will change

* Update api-gateway.yml

Another addition to set the x-Content-Type-Options to nosniff

* Update api-gateway.yml

Fix error where code was placed

* ignore email records for package builder

---------

Co-authored-by: Dark-Knight-1313 <[email protected]>
updated email notification text to state for subsequent submissions
updated text in email notification for cms for subsequent submissions
…1482)

* update subsequent submission additional information text

* added conditional text on the package details page for sub subs

---------

Co-authored-by: Andie Swift <[email protected]>
@andieswift andieswift changed the base branch from develop to subsub2 August 27, 2024 20:17
@bflynn-cms bflynn-cms changed the base branch from subsub2 to develop August 28, 2024 15:23
@andieswift andieswift self-assigned this Aug 30, 2024
@Enterprise-CMCS Enterprise-CMCS deleted a comment from github-actions bot Aug 30, 2024
Copy link

Endpoint URL - https://d1xwr2frq98eh7.cloudfront.net

@andieswift andieswift merged commit 02e3f96 into develop Sep 4, 2024
99 of 103 checks passed
@andieswift andieswift deleted the oy2-29760 branch September 4, 2024 19:26
bflynn-cms added a commit that referenced this pull request Sep 19, 2024
* Update sub sub email language (#1499)

* OY2-28760 - updated language in the sub sub email notifications to match docs 
---------
Co-authored-by: Andie Swift <[email protected]>
---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: bflynn-cms <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Dark-Knight-1313 <[email protected]>
Co-authored-by: Mike Dial <[email protected]>

* ensure subsequent submission is only for users with access to submit packages (#1503)

Co-authored-by: Dark-Knight-1313 <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andie Swift <[email protected]>
Co-authored-by: Kristin Grue <[email protected]>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Valencia McMurray <[email protected]>
Co-authored-by: Dark-Knight-1313 <[email protected]>
Co-authored-by: Mike Dial <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants