Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OY2 24488: Data not Cleared with SEA Tool Update #1300

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Conversation

kristin-at-theta
Copy link
Collaborator

Story: https://qmacbis.atlassian.net/browse/OY2-24488
Endpoint: See github-actions bot comment

Details

Code successfully creates the correct dates when they first are entered, and also updates properly if the dates change, but does not recognize if a date has been removed. The details page for the package still contains the Final Disposition Date and the Approved Effective Date from the old SEA Tool event.

Changes

  • converted the proposedEffectiveDate field to use emptyField rather than "none" (for consistency)
  • added "else" actions to reset the approvedEffectiveDate and finalDispositionDate if they are no longer numbers
  • updated the UI to handle both emptyField and dates in the response

Test Plan

  1. Login as a OneMAC User that can view packages
  2. Find a package with an Approved Effective Date
  3. Use the AWS console to update the latest SEA Tool Event and remove the STATE_PLAN->APPROVED_EFFECTIVE_DATE and/or STATE_PLAN->ACTUAL_EFFECTIVE_DATE
  4. Verify the Approved Effective Date is removed from the package
  5. Find a package in a Final Status (Package Withdrawn, Approved, Disapproved)
  6. Use the AWS console to update the latest SEA Tool Event and change the status to a non-final status (like: Pending)
  7. Verify the Final Disposition Date is removed from the package

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Endpoint URL - https://d2lz69yzdtrc97.cloudfront.net

@kristin-at-theta kristin-at-theta marked this pull request as ready for review July 7, 2023 13:05
Copy link
Collaborator

@bflynn-cms bflynn-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kristin-at-theta kristin-at-theta merged commit d37ba51 into develop Jul 14, 2023
93 checks passed
@kristin-at-theta kristin-at-theta deleted the oy2-24488 branch July 14, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants