Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GV Refactor - validateAtLeastOneDataSourceType #2449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ailZhou
Copy link
Collaborator

@ailZhou ailZhou commented Sep 25, 2024

Description

Found another validation that is used in 2023+ reporting year. This is checking that when a user select a data source, that they also remember to select any child data sources or fill out and child textboxes.

Related ticket(s)

N/A


How to test

  1. Sign into QMR, any user
  2. Select an Child CoreSet in Reporting Year 2024
  3. Go to IMA-CH
  4. In the Data Source Section, select the checkboxes below:

localhost_3001_WA_2024_CCSC_IMA-CH (1)

  1. Validate and you should see these errors for data source
Screenshot 2024-09-25 at 4 18 15 PM

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit be7cf8b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 86.0% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant