Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMDCT-3843] react-query 5.0.5 (2 major versions) + React 18 #2365

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

BearHanded
Copy link
Contributor

@BearHanded BearHanded commented Aug 8, 2024

Description

react-query introduces vulns unless upgraded to 5.0.5.
To do that we have to move to React 18.

To do both of those things we have to change some imports and comply with new method signatures.
These new changes were likely made just because some developer somewhere felt like it. Modern JS development is cursed.

The updated react-query devtools add a little icon to the screen, and I have used a recommended pattern to only show that in local development. We can adjust to more or less.

Related ticket(s)

CMDCT-3843


How to test

Try everything. Both of these packages touch everything.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Aug 8, 2024

Code Climate has analyzed commit b3bb949 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 82.3% (0.0% change).

View more on Code Climate.

@ailZhou ailZhou mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant