Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled state for dashboard buttons #767

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

jessabean
Copy link
Contributor

@jessabean jessabean commented Sep 20, 2024

Description

This is a hotfix for a bug I noticed: the disabled buttons and links on the work plan dashboard were extremely light and do not meet accessibility contrast standards

Related ticket(s)

N/A

How to test

  1. Log in as a state user and create a work plan
  2. Stay on the dashboard and see the disabled "Continue MFP Work Plan" and "Reset MFP Work Plan" buttons. They should be legible.

Before

Screenshot 2024-09-20 at 9 49 48 AM

After

Screenshot 2024-09-20 at 10 12 27 AM

Copy link

codeclimate bot commented Sep 20, 2024

Code Climate has analyzed commit 616553d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 92.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this an approval cause I actually disagree with WCAG here, but to my knowledge we don't actually need to meet color contrast for disabled elements. In WCAG it states that "Text or images of text that are part of an inactive user interface component, ... have no contrast requirement." So buttons that are disabled can be greyed out. Still, I don't think this hurts anything so take my 👍

@jessabean
Copy link
Contributor Author

I'll give this an approval cause I actually disagree with WCAG here, but to my knowledge we don't actually need to meet color contrast for disabled elements. In WCAG it states that "Text or images of text that are part of an inactive user interface component, ... have no contrast requirement." So buttons that are disabled can be greyed out. Still, I don't think this hurts anything so take my 👍

oooh, TIL!! In any case, the extra light disabled state does not match the CMSDS disabled styles, so yes...I'll take your 👍🏻 lol

@jessabean jessabean merged commit 98a6060 into main Sep 20, 2024
21 checks passed
@jessabean jessabean deleted the je-fix-buttons-dashboard branch September 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants