Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main → val #756

Merged
merged 14 commits into from
Sep 20, 2024
Merged

main → val #756

merged 14 commits into from
Sep 20, 2024

Conversation

jessabean
Copy link
Contributor

@jessabean jessabean commented Sep 17, 2024 •
edited by gmrabian
Loading

test → val

In this deployment:

  • Revert db:seed for Playwright tests
  • Add storage helpers for banners and templates
  • Move reset button to dashboard (CMDCT-3882)
  • Block destroy on deploy
  • Slack alert for failed destroy action (CMDCT-3659)
  • Page object model for Playwright tests
  • Organize theme files (CMDCT-3779)
  • Upgrade @emotion/styled
  • Improve checks for existing report (CMDCT-3985)
  • Organize Playwright helper functions
  • Add smart quotes and apostrophes to report instructions (CMDCT-3981)
  • Fix padding in instructions list (CMDCT-3982)
  • Update macfc security hub github action (CMDCT-3994)
  • Adjust entity row alignment (CMDCT-3980)

@jessabean jessabean marked this pull request as ready for review September 17, 2024 14:45
gmrabian
gmrabian previously approved these changes Sep 17, 2024
View reviewed changes
karla-vm
karla-vm previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jessabean jessabean merged commit 45e8834 into val Sep 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsummers1 ntsummers1 ntsummers1 approved these changes

@gmrabian gmrabian gmrabian approved these changes

@karla-vm karla-vm karla-vm left review comments

@BearHanded BearHanded Awaiting requested review from BearHanded BearHanded is a code owner

@braxex braxex Awaiting requested review from braxex braxex is a code owner

Assignees

@jessabean jessabean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jessabean @ntsummers1 @gmrabian @karla-vm @bangbay-bluetiger @benmartin-coforma @berryd @dwhitestratiform @mdct-github-service-account @britt-mo