Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFP] General Information Page #66

Merged
merged 5 commits into from
Aug 31, 2023
Merged

[MFP] General Information Page #66

merged 5 commits into from
Aug 31, 2023

Conversation

ajaitasaini
Copy link
Contributor

@ajaitasaini ajaitasaini commented Aug 24, 2023

Description

Added general information page to WP report submission process

Related ticket(s)

MDCT-2758


How to test

when json is passed into mock object:
Screenshot 2023-08-24 at 10 08 47 AM

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@ajaitasaini ajaitasaini changed the title [MFP] General Information Page [MFP] General Information Page (MOCK DATA - DO NOT MERGE) Aug 28, 2023
@ajaitasaini ajaitasaini changed the title [MFP] General Information Page (MOCK DATA - DO NOT MERGE) [MFP] General Information Page Aug 30, 2023
@ajaitasaini ajaitasaini marked this pull request as ready for review August 30, 2023 19:52
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need the User Guide and Help file url?

@ajaitasaini
Copy link
Contributor Author

ajaitasaini commented Aug 30, 2023

Does this need the User Guide and Help file url?

@britt-mo I was told they were TBD, not sure if I should wait to merge until those urls are ready

Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think it's fine to add that url in later if it's still TBD, just wanted to confirm it wasn't missed.

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit a0acbcc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 78.1% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm merged commit 7d368a3 into main Aug 31, 2023
11 checks passed
@karla-vm karla-vm deleted the mdct-2758-generalinfo branch August 31, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants