-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDCT-2759 + 2760: Transition Benchmarks w/ Drawer #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked good in the browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Code Climate has analyzed commit 72787a2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 75.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 77.9% (-0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Creating the
Transition Benchmarks
page with its corresponding drawerRelated ticket(s)
MDCT-2759
MDCT-2760
How to test
/wp/transition-benchmarks
You should see the corresponding data and styling!
Important updates
Author checklist
convert to a different template: test → val | val → prod