Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-2759 + 2760: Transition Benchmarks w/ Drawer #65

Merged
merged 11 commits into from
Aug 31, 2023
Merged

Conversation

karla-vm
Copy link
Contributor

Description

Creating the Transition Benchmarks page with its corresponding drawer

Related ticket(s)

MDCT-2759
MDCT-2760


How to test

  • Log in as a state user
  • Navigate to /wp/transition-benchmarks

You should see the corresponding data and styling!

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

britt-mo
britt-mo previously approved these changes Aug 23, 2023
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good in the browser

keeysnc
keeysnc previously approved these changes Aug 24, 2023
Copy link
Contributor

@keeysnc keeysnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karla-vm karla-vm changed the title MDCT-2759 + 2760: Transition Benchmarks w/ Drawer (Mock Data) MDCT-2759 + 2760: Transition Benchmarks w/ Drawer Aug 30, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit 72787a2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 77.9% (-0.1% change).

View more on Code Climate.

@keeysnc keeysnc self-requested a review August 30, 2023 19:07
Copy link
Contributor

@keeysnc keeysnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@keeysnc keeysnc self-requested a review August 31, 2023 15:34
@karla-vm karla-vm merged commit c905959 into main Aug 31, 2023
11 checks passed
@karla-vm karla-vm deleted the transitions-2759 branch August 31, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Just a draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants