-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): move breadcrumbs from labelMappers
to ActionForm
#797
Conversation
Code Climate has analyzed commit 91f4697 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 60.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.1% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
🚢 |
Purpose
To further consolidate form logic into
ActionForm
, we should control more aspects of the form's appearance in the component. Previously, the breadcrumb text was determined by an object. This PR moves that logic intoActionForm
.Approach
ActionForm
and a test as wellformOrigin