feat: add er spa #793
feat: add er spa #793
Conversation
daniel-belcher
added
type: FEAT
daniel-belcher
requested review from
charmcitygavin,
benjaminpaige and
jdinh8124
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
daniel-belcher
temporarily deployed
to
er-spa
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
er-spa
GitHub Actions
Inactive
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| }); | ||
| } else { | ||
| return !!dependentValue[i] && !(dependentValue[i] === d?.expectedValue); |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| } | ||
| case "notOnlyBadValue": | ||
| if (Array.isArray(dependentValue[i])) { | ||
| return !( |
There was a problem hiding this comment.
Avoid too many return statements within this function.
| ); | ||
| }; | ||
|
|
||
| const triggerCheckSwitch = ( |
There was a problem hiding this comment.
Function triggerCheckSwitch has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
| ]); | ||
| let newValArr = [...value, ...dependency.effect.newValue]; | ||
|
|
||
| if (dependency.effect.checkUnique) |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| ]); | ||
| let newValArr = [...value, dependency.effect.newValue]; | ||
|
|
||
| if (dependency.effect.checkUnique) |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit d3d83a0 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 28.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (-0.1% change). View more on Code Climate. |
daniel-belcher
temporarily deployed
to
er-spa
GitHub Actions
Inactive
daniel-belcher
temporarily deployed
to
er-spa
GitHub Actions
Inactive
Purpose
Add ER Spa. Also added some new options to dependency wrapper and section styling as needed for the form. New options include checking for bad values as a condition, loose condition matching for checking if at least one condition matched, and section styling for the wrapper of the content.
Linked Issues to Close
ticket
Approach
New dependency conditions are a base approach checking if value included in either array or primitive. Section styling follows our normal styling approach of merging with our pre-defined styles. Form is massive, extracted as many repeatable sections as possible, but it's still a lot to go through.