struct should allow a "constructor" field name

Effect-TS · Jun 30, 2023 · 060ce80 · 060ce80
1 parent d57c92f
commit 060ce80
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/funny-grapes-lie.md b/.changeset/funny-grapes-lie.md
@@ -0,0 +1,5 @@
+---
+"@effect/schema": patch
+---
+
+struct should allow a "constructor" field name
diff --git a/src/AST.ts b/src/AST.ts
@@ -752,7 +752,7 @@ export const createTypeLiteral = (
   const keys: Record<PropertyKey, null> = {}
   for (let i = 0; i < propertySignatures.length; i++) {
     const name = propertySignatures[i].name
-    if (name in keys) {
+    if (Object.prototype.hasOwnProperty.call(keys, name)) {
       throw new Error(`Duplicate property signature ${String(name)}`)
     }
     keys[name] = null

diff --git a/test/Schema.ts b/test/Schema.ts
@@ -66,6 +66,11 @@ describe.concurrent("Schema", () => {
     expect(S.clampBigint).exist
   })
 
+  it("struct should allow a \"constructor\" field name", () => {
+    const schema = S.struct({ constructor: S.string })
+    expect(schema.ast._tag).toEqual("TypeLiteral")
+  })
+
   it("brand/ annotations", () => {
     // const Branded: S.Schema<number & Brand<"A"> & Brand<"B">>
     const Branded = pipe(