Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpn): save lastDir when opening a file #5161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pagrey
Copy link

@pagrey pagrey commented Jun 12, 2024

Fixes #5157 and fixes #4813

Summary of changes:
Ignores updateLastUsedDir boolean and updates the last directory used.

I don't know the purpose of not saving the last used directory and I don't know the impact of removing all the code associated with removing this boolean value so I set it true so the directory is updated. Companion hasn't updated the directory location in seven years but these two issues reference the problem and this is a very simple fix.

@pfeerick pfeerick added bug 🪲 Something isn't working companion Related to the companion software labels Jun 12, 2024
@pfeerick pfeerick changed the title Save lastDir when opening a file fix(cpn): save lastDir when opening a file Jun 12, 2024
@elecpower elecpower self-requested a review June 12, 2024 21:31
@elecpower
Copy link
Collaborator

My personal preference is to update the last used directory on save as this would normally be where you store the majority of your files whereas opening files could be from more varied locations such as main storage location, backups, usb drives, downloads, emails, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working companion Related to the companion software
Projects
None yet
3 participants