-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative transmit data: #4351 #4386
base: main
Are you sure you want to change the base?
Conversation
Please rebase rather than merge main where possible, as this keeps the commit history and changes clearer. It's not so much of an ordeal if you do it regularly, as the conflicts / changes become minimal, and often need to be resolved with after merge commits anyway, which adds even more noise. |
Mmh, I did a rebase ... |
If you have no objections, I can push that through as I rebased it locally and just need to push it back to this branch. You'll just need to reset your local copy to the state of the remote branch in order to continue working on it. |
Well, I'm not a real git guru ;-) We can do as you suggested above (then you have to guide me a bit for my local repo), or I can delete the PR and setup a new branch and PR ... choose the way that means the least work for you! |
This PR will just provide the basic infrastructure for sending data to the RX/FC/..., it is left to some LUA to actually push that data via crossfileTelemetryPush(), sportTelemetryPush() (or TelemetryPush(), e.g. = mavlink) according to the needs of the user and his infrastructure in the model. |
I think the option should be off by default, not on Also some TRACES are left commented out, some not |
Yes, any supporting Lua code would go in the edgetx-sdcard repo. rebase has been pushed. And don't worry, I'm not a git guru either... I've just learnt a bit over the past few years having to use it more and more ;) Using the command line, do a you can then do |
simplified data handling
Thanks, looks good now. |
const uint8_t start = mNextIndex; | ||
for(uint8_t i = 0; i < numberOfValuesToPush; ++i) { | ||
const uint8_t v = mData[mNextIndex]; | ||
TRACE("pushNextData: %d = %d", mNextIndex, v); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TRACE really needed ?
simplified data handling
simplified data handling
simplified data handling
WIP: first try for: #4351