Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: update to LUA 5.3 #4203

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chores: update to LUA 5.3 #4203

wants to merge 7 commits into from

Conversation

raphaelcoeffic
Copy link
Member

Preview of what is coming for 3.0...

@JimB40
Copy link
Collaborator

JimB40 commented Oct 15, 2023

Will it increase memory demand? Something is ringing in my head that 5.3 has 32bit numbers so it takes more mem.

@raphaelcoeffic
Copy link
Member Author

Will it increase memory demand? Something is ringing in my head that 5.3 has 32bit numbers so it takes more mem.

The current LUA version we are using only supports 64Bit floating point. So I expect the memory usage to be reduced.

@pfeerick pfeerick requested a review from JimB40 December 9, 2023 03:33
@pfeerick pfeerick added the rebase needed A git rebase on top of the latest destination branch version is required. label Dec 9, 2023
@pfeerick pfeerick removed the rebase needed A git rebase on top of the latest destination branch version is required. label Dec 9, 2023
@LupusTheCanine
Copy link
Contributor

Hi, what is the status of this?

@gagarinlg
Copy link
Member

This will come with EdgeTX 3.0. we want to have one release where we combine multiple incompatible changes, to make life easier for the lua Devs.

@pfeerick pfeerick added this to the 3.0 milestone Jun 17, 2024
@pfeerick pfeerick modified the milestones: 3.0, 2.11 Aug 18, 2024
@pfeerick pfeerick added the rebase needed A git rebase on top of the latest destination branch version is required. label Aug 18, 2024
@JimB40
Copy link
Collaborator

JimB40 commented Aug 20, 2024

@raphaelcoeffic when you rebase pls ping me so I can make some tests.

@philmoz
Copy link
Collaborator

philmoz commented Aug 21, 2024

Rebased to current main; but having issues with crashes to EM and stack overflow in widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request lua rebase needed A git rebase on top of the latest destination branch version is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants