feat: allow partial subjects #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Throw `Feature::Subject::NotApplicable` when an invalid subject is specified. This allows for better differentiation of error cases. Given a feature specified as: ```yaml user: id: 1 ``` and a feature check like `Feature.enabled?(:check, user_id: 1)` then when the feature was modified to include *additional* constraints like ```yaml user: id: 1 age: gt: 3 ``` every caller would immediately fail with `Feature::Subject::Invalid`. In production this creates an intensely tight coupling between the caller and feature data source that is effectively impossible to safely modify. By allowing *partial subject checks* the coupling is removed, allowing for data source additions without active caller errors.
nwithan8
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw
Feature::Subject::NotApplicablewhen an invalid subject is specified. This allows for better differentiation of error cases.Given a feature specified as:
and a feature check like
Feature.enabled?(:check, user_id: 1)then when the feature was modified to include additional constraints likeevery caller would immediately fail with
Feature::Subject::Invalid. In production this creates an intensely tight coupling between the caller and feature data source that is effectively impossible to safely modify.By allowing partial subject checks the coupling is removed, allowing for data source additions without active caller errors.
If a subject is specified by the caller but removed from the data source, an error is still created.