Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup build deps #314

Merged
merged 4 commits into from
Dec 5, 2023
Merged

chore: cleanup build deps #314

merged 4 commits into from
Dec 5, 2023

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Dec 5, 2023

Description

When we swapped from building our own packages to using the build packages, we forgot to remove wheel which is no longer needed. Additionally, build just hit v1 so it's a good time to upgrade. No breaking changes affect us

Testing

Ran make build and it worked as expected producing the stdist and wheel still

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team December 5, 2023 21:16
@Justintime50 Justintime50 merged commit 943e1ae into master Dec 5, 2023
8 checks passed
@Justintime50 Justintime50 deleted the upgrade_build branch December 5, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants