Adds support for claims API #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
previously approved these changes
Jul 23, 2024
| expect(firstIdOfFirstPage).to.not.equal(firstIdOfSecondPage); | ||
| } catch (error) { | ||
| if (!(error instanceof EndOfPaginationError)) { | ||
| throw new Error('Test failed intentionally'); |
There was a problem hiding this comment.
I believe this logic is backwards? Getting an EndOfPaginationError is fine and is the eventual expected path. Getting any other error is an error. Perhaps the wording "intentionally" is invalid here.
There was a problem hiding this comment.
Hmmm... I just copy-pasted this from insurance's tests. I'm not quite sure I understand?
Getting an EndOfPaginationError is fine and is the eventual expected path
Yea, I think thats what this is counting on. If it's not an EndOfPaginationError, then throw an error.
I can probably refactor this to be more clear what we are doing with something like
if (error instanceof EndOfPaginationError) {
// all gucci
return;
}
throw error
nwithan8
requested changes
Jul 23, 2024
ralexmatthews
changed the title
nwithan8
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates the model, service, tests, and types for the claims API.
Also fixes a minor issue with the beta APIs where it added two slashes, making it like
//beta/whateverTesting
Adds new tests based off the existing insurance tests
Pull Request Type
Please select the option(s) that are relevant to this PR.