Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DateDeserializer #334

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Remove DateDeserializer #334

merged 2 commits into from
Sep 16, 2024

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Sep 11, 2024

Description

This PR closes #333. The DateDeserilizer was created to handle an edge case from our API response for date format. We have corrected the date format at the API level, so the DateDeserilizer has been removed.

Testing

Re-recorded cassettes to ensure we have the latest response for Claims, date was parsed correctly

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team September 11, 2024 20:29
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I believe we can fix this at the API level. Let's see if that's true before moving on this.

@jchen293 jchen293 changed the title Fix date format parsing issue, close Java GitHub issue 333 Remove DateDeserializer, close Java GitHub issue 333 Sep 16, 2024
@jchen293 jchen293 merged commit ac02505 into master Sep 16, 2024
18 checks passed
@jchen293 jchen293 deleted the fix_parse_date branch September 16, 2024 19:49
@nwithan8 nwithan8 changed the title Remove DateDeserializer, close Java GitHub issue 333 Remove DateDeserializer Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Datetime not parsing the timestamp.
3 participants