Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Re-record all cassettes #300

Merged
merged 3 commits into from
Jan 8, 2024
Merged

[chore] Re-record all cassettes #300

merged 3 commits into from
Jan 8, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Dec 27, 2023

Description

  • Re-record all cassettes (see issues below)
  • Import examples submodule

Testing

  • All unit tests pass, except:
    • ReferralTest.testReferralAddCreditCard cassette was not re-recorded, as the API now rejects the Stripe test credit card we use for the unit test, causing the test to fail. Instead, we'll keep the original cassette when the API did not check this.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 marked this pull request as ready for review January 6, 2024 00:15
@nwithan8 nwithan8 requested a review from a team January 6, 2024 00:15
@nwithan8 nwithan8 merged commit 3fb646b into master Jan 8, 2024
17 checks passed
@nwithan8 nwithan8 deleted the cassettes branch January 8, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants