Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: maps 400 status codes to BadRequestError class #278

Merged
merged 2 commits into from
Jul 21, 2023
Merged

feat: maps 400 status codes to BadRequestError class #278

merged 2 commits into from
Jul 21, 2023

Conversation

Justintime50
Copy link
Member

Description

Maps 400 status codes to the new BadRequestError class

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team July 21, 2023 15:36
jchen293
jchen293 reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@jchen293 jchen293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the test here: https://github.com/EasyPost/easypost-java/blob/master/src/test/java/com/easypost/ErrorTest.java#L66

nwithan8
nwithan8 previously approved these changes Jul 21, 2023
View reviewed changes
@Justintime50 Justintime50 merged commit abb6763 into master Jul 21, 2023
16 checks passed
@Justintime50 Justintime50 deleted the bad_request_error branch July 21, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@nwithan8 nwithan8 nwithan8 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293