[Feature] Add library hooks #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwithan8
requested changes
Jul 5, 2023
nwithan8
reviewed
Jul 6, 2023
nwithan8
requested changes
Jul 6, 2023
nwithan8
approved these changes
Jul 6, 2023
dcaballeroc
approved these changes
Jul 7, 2023
Comment on lines
+62
to
+71
| public static Object testRequestHooks(RequestHookResponses datas) { | ||
| assertEquals("https://api.easypost.com/v2/parcels", datas.getPath()); | ||
| assertEquals("POST", datas.getMethod()); | ||
| assertNotNull(datas.getHeaders()); | ||
| assertNotNull(datas.getRequestBody()); | ||
| assertNotNull(datas.getRequestTimestamp()); | ||
| assertNotNull(datas.getRequestUuid()); | ||
|
|
||
| return true; | ||
| } |
There was a problem hiding this comment.
I'd like to see a follow-up PR where we rename datas to data. People will use tests as an example and datas plural doesn't make sense.
Same with RequestHookResponses should not be plural and be RequestHookResponse instead
| */ | ||
| @Test | ||
| public void testCreateParcelWithRequestHook() throws EasyPostException { | ||
| vcr.setUpTest("create"); |
There was a problem hiding this comment.
I'd like if we renamed the create to something different since we aren't really creating a hook but are instead capturing the details of a request that we hooked into. Renaming the cassette will help reduce confusion about its purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestHookandResponseHookclasses. (un)subscribe to them with the newsubscribeToRequestHook,subscribeToResponseHook,unsubscribeFromRequestHook, orunsubscribeFromResponseHookmethods of anEasyPostClientTesting
Add new unit tests
Pull Request Type
Please select the option(s) that are relevant to this PR.