docs: create <VerticalNav /> spec
#762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenjwatkins
changed the title
<VerticalNav /> spec<VerticalNav /> spec
OskiTheCoder
reviewed
Nov 8, 2023
| } | ||
| ``` | ||
|
|
||
| _Expandable vertical nav:_ |
There was a problem hiding this comment.
question: on mobile will the popover be implemented with a menu or listbox?
There was a problem hiding this comment.
good question. this may change after getting into the thick of implementation, but i think we can just keep it as the same implementation type (nav) on mobile since the behavior doesn't change from desktop to mobile. it would just be rendered as such in the container that changes to a "floating card" appearance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Changes
<VerticalNav />component