Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Card): support shadow variant #1391

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(Card): support shadow variant #1391

wants to merge 3 commits into from
+113 −7

Conversation

stephenjwatkins
Copy link
Contributor

@stephenjwatkins stephenjwatkins commented Oct 8, 2024 •
edited
Loading

📝 Changes

  • Add support for <Card variant="shadow" />
  • Add support for custom shadow levels per Figma design system <Card variant="shadow" shadowLevel="2" />

✅ Checklist

Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:

  • Visuals match Design Specs in Figma
  • Stories accompany any component changes
  • Code is in accordance with our style guide
  • Design tokens are utilized
  • Unit tests accompany any component changes
  • TSDoc is written for any API surface area
  • Specs are up-to-date
  • Console is free from warnings
  • No accessibility violations are reported
  • Cross-browser check is performed (Chrome, Safari, Firefox)
  • Changeset is added

Strikethrough any items that are not applicable to this pull request.

@stephenjwatkins stephenjwatkins marked this pull request as ready for review October 8, 2024 20:26
@stephenjwatkins stephenjwatkins marked this pull request as draft October 8, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stephenjwatkins